Damien Cassou DamienCassou
Repositories Public Activity Starred Repositories
Loading Heatmap…

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

can you please describe some more what type of variable it is and what is stored in there?

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

should the first parameter of `navigel-refresh` be deleted? It doesn't seem we use it anymore.

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

I guess this variable should be made private

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

I think `map-delete` reveals intention better.

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

can you please rename `k` to something more explicit such as `id`?

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

it makes sense, thanks for the clarification

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

ok, keep it there

1 day ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

I think this function could be made private with a double-dash.

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

find => return

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

we are talking about "Applications using..." so I suggest "none" instead of "never".

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

can you please introduce that in a separate PR that we could quickly merge? I think `navigel-equal` could use this by default instead of `equal`.

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

please add to the docstring some info about the keys as well. Something like:

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

I would inline the function `navigel--app-buffer` inside this one as I don't see the rationale for having 2 functions.

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

are there cases where `app` is nil? Where `navigel-app` is nil?

4 days ago

DamienCassou commented on issue DamienCassou/navigel#6

Per application single-buffer mode

Some initial feedback. I'm still not done though.

4 days ago

DamienCassou merged pull request DamienCassou/makel#5

Add makem.sh

1 week ago

DamienCassou closed pull request DamienCassou/makel#5

Add makem.sh

1 week ago

DamienCassou pushed to master at DamienCassou/makel

1 week ago