commented on issue DamienCassou/navigel#6
can you please describe some more what type of variable it is and what is stored in there?
1 day ago
should the first parameter of `navigel-refresh` be deleted? It doesn't seem we use it anymore.
I guess this variable should be made private
I think `map-delete` reveals intention better.
can you please rename `k` to something more explicit such as `id`?
it makes sense, thanks for the clarification
ok, keep it there
I think this function could be made private with a double-dash.
4 days ago
find => return
we are talking about "Applications using..." so I suggest "none" instead of "never".
can you please introduce that in a separate PR that we could quickly merge? I think `navigel-equal` could use this by default instead of `equal`.
please add to the docstring some info about the keys as well. Something like:
I would inline the function `navigel--app-buffer` inside this one as I don't see the rationale for having 2 functions.
are there cases where `app` is nil? Where `navigel-app` is nil?
Some initial feedback. I'm still not done though.
merged pull request DamienCassou/makel#5
1 week ago
closed pull request DamienCassou/makel#5
pushed to master at DamienCassou/makel