jao deleted branch directory-bookmarks from jao/mpdel

1 year ago

jao commented on pull request mpdel/mpdel#30

thanks to you, damien, and happy new year!

1 year ago

jao commented on pull request mpdel/mpdel#30

er, do you mean with an *additional* blank line?

1 year ago

jao commented on pull request mpdel/mpdel#30

hmm, i want the context to be specifically mpdel-browser-mode and don't care really care about navigel-app to be set, which is what i understand navigel-method would give me for free: am i mistaken?

1 year ago

jao created pull request mpdel/mpdel#30

1 year ago

jao closed pull request mpdel/mpdel#26

1 year ago

jao commented on pull request mpdel/mpdel#26

Hi, and, first of all, apologies for the long delay. I've been using this pr for a while during the last months, and i've got mixed feelings about it, specially with the mix of modes, and no clear…

1 year ago

jao commented on pull request mpdel/mpdel#26

per-type single buffer is non-trivial in the current state, so it'll take a bit of effort. so perhaps here we could just first clean things up a bit, do the `[` keybinding and merge? [sorry it takes so long for me to answer lately... busy times, and, also, the fact that i have to use a browser to comment always makes me forget!]

2 years ago

jao commented on pull request mpdel/mpdel#26

`[` sounds good to me. In time we could even have some kind of ring buffer and enable `]`, but i don't see a pressing need right now. If we do that, and unify the meaning of `^`, are you also okay with having just a single tablist major mode for all buffers, or does it still make sense to have a separate one for the results of searches? In this PR, using single-buffer mode means that everything mpdel shows goes to the same buffer, so, for instance, a search will overwrite whatever directory one is visiting; asking for the current playlist could show it in a buffer previously showing a search result; and so on and so forth. I am starting to think that that's probably not great. Maybe 'single buffer' should apply only to results of browsing 'directories' (i'm quoting it because when one uses a backend such as mopidy that can access remote services such as spotify, one sees entries there logically organized as folders, although obviously they don't map to any local file system), and then have another 'single buffer' dedicated to searches, and yet another dedicated to the current playlist. In that way we'd be a bit like ncmpcpp and similar clients, which is a modus operandi i don't dislike. What do you think?

2 years ago

jao commented on pull request mpdel/mpdel#26

if one goes to the browser's main page and opens a directory, the buffer is in browser-mode and ^ will go back to the parent of the directory, no matter where point in the buffer is. if one goes to the list of albums from the browser's main page, one ends in a different mode mpdel-tab (which is already a bit of a surprise) and if presses ^ in a given position, one does not return to the main page, but sees a list of the parents of the entry at point. so when navigating with the browser one ends up in modes that behave differently, which is a bit jarring specially in single-window mode (or at least i find it a bit jarring)...

2 years ago

jao commented on pull request mpdel/mpdel#26

so, in my normal use of mpdel, i often get confused to the switch to `mpdel-tablist-mode` for some views, like search results or the list of artists, specially because we've given a way to get there with the links in the browser's top level. what's confusing there is that, when i come from the browser, i expect ^ to bring me back to the top-level, but in `mpdel-tablist-mode` that's not always so, one goes to the entity at point's parent. a possible solution would be to keep a single mode, mdpel-browse-mode, but don't change there the meaning of ^ (i.e., keep it as entity at point's parent), and then provide a new shortcut for "Back to previously browsed buffer" (which is now, arguably erroneously, bound to ^). both operations would be the same when the entity at point is "..", but not in general. does that make sense?

2 years ago

jao closed pull request mpdel/libmpdel#20

2 years ago

jao commented on pull request mpdel/libmpdel#20

yes, you're right. i mistook this change for something pending i had to send. my bad. closing!

2 years ago

jao commented on pull request mpdel/mpdel#26

mmm. to me it's browser mode, but perhaps this should be customizable? (as an aside, sorry for taking so long to anwser, but i didn't receive any mail notifications of your latest comments)

2 years ago

jao created pull request mpdel/libmpdel#20

2 years ago

jao created pull request mpdel/mpdel#26

2 years ago