#20 Bug fix: set a default parent for albums without artist

Closed
jao wants to merge 1 commits from jao:master into master
jao commented 1 year ago
Collaborator

In the 'albums children view, some entries may have empty artists, in
which case the corresponding parent defaults to the top level.

In the 'albums children view, some entries may have empty artists, in which case the corresponding parent defaults to the top level.
DamienCassou requested changes 1 year ago
(cl-defmethod libmpdel-artist ((album libmpdel-album))
"Return the ALBUM's artist."
(libmpdel--album-artist album))
(let ((artist (libmpdel--album-artist album)))
DamienCassou commented 1 year ago

I disagree with this change. I think an album's artist should be an object of type libmpdel-artist (or nil at worst). I suggest you make a similar change by overriding navigel-parent-to-open.

I disagree with this change. I think an album's artist should be an object of type `libmpdel-artist` (or `nil` at worst). I suggest you make a similar change by overriding `navigel-parent-to-open`.
jao commented 1 year ago

yes, you're right. i mistook this change for something pending i had to send. my bad. closing!

yes, you're right. i mistook this change for something pending i had to send. my bad. closing!
jao closed this pull request 1 year ago
All checks were successful
continuous-integration/drone/pr Build is passing
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.