#28 [#27] Implement libmpdel-stored-playlists-delete

Merged
DamienCassou merged 1 commits from tangrammer/libmpdel:master into master 10 months ago

so it could be used from mdel-playlist library to remove stored playlists using navigel too :) ... coming soon a PR for mpdel repo

so it could be used from mdel-playlist library to remove stored playlists using navigel too :) ... coming soon a PR for mpdel repo
tangrammer added 1 commit 11 months ago
4c1627a882 Implement libmpdel-stored-playlists-delete
Poster
Owner

Great job, thank you!

Great job, thank you!
DamienCassou requested changes 11 months ago
DamienCassou left a comment

Good job. Please handle the small feedback and rebase your PR on top of latest master. Then we can merge.

Next time, I suggest you create a dedicated PR branch and give me write access to it. This way, I can do that kind of changes myself and merge right away.

libmpdel.el Outdated
(format "rm %S" (libmpdel-entity-name s)))
stored-playlists)))
DamienCassou commented 11 months ago

Can you please delete this useless line? Only one is necessary.

Can you please delete this useless line? Only one is necessary.
tangrammer added 1 commit 11 months ago
Poster

Next time, I suggest you create a dedicated PR branch and give me write access to it. This way, I can do that kind of changes myself and merge right away.

Perfect! I'll do it :)

> Next time, I suggest you create a dedicated PR branch and give me write access to it. This way, I can do that kind of changes myself and merge right away. > Perfect! I'll do it :)
tangrammer requested review from DamienCassou 11 months ago
tangrammer force-pushed master from 14ee6b8c27 to 534467ed89 11 months ago
Poster

rebased too (just forgot to do it before!)

rebased too (just forgot to do it before!)
Poster
Owner

Final step: can you please squash your 2 commits into just one?

Final step: can you please squash your 2 commits into just one?
DamienCassou refused to review 11 months ago
tangrammer force-pushed master from 534467ed89 to 6f489c356e 11 months ago
tangrammer requested review from DamienCassou 11 months ago
DamienCassou merged commit 9162a4b350 into master 10 months ago
Poster
Owner

Awesome. Thank you.

Awesome. Thank you.

Reviewers

DamienCassou was requested for review 11 months ago
The pull request has been merged as 9162a4b350.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.