#28 Unix sockets

Open
opened 1 year ago by nobrowser · 4 comments
nobrowser commented 1 year ago

Please consider a way to connect to a MPD daemon that serves on a Unix socket.

Other clients (such as mpc and ncmpc) follow the convention that when a "host" setting starts with a slash, it is really a path name for a Unix socket connection. I tried that with mpdel but from the error message I saw that it was just connecting over TCP to a host with that name, which obviously couldn't work :-(

Then I thought that Emacs simply didn't support Unix sockets for open-network-stream, but that turned out to be false, as can be read (carefully!) from the Elisp manual section on network processes.

So, it would be great (and easy, I believe) to add them. I can make a patch, given some encouragement that it would be accepted (I don't want to maintain a personal fork of mpdel).

Please consider a way to connect to a MPD daemon that serves on a Unix socket. Other clients (such as `mpc` and `ncmpc`) follow the convention that when a "host" setting starts with a slash, it is really a path name for a Unix socket connection. I tried that with `mpdel` but from the error message I saw that it was just connecting over TCP to a host with that name, which obviously couldn't work :-( Then I thought that Emacs simply didn't support Unix sockets for `open-network-stream`, but that turned out to be false, as can be read (carefully!) from the Elisp manual section on network processes. So, it would be great (and easy, I believe) to add them. I can make a patch, given some encouragement that it would be accepted (I don't want to maintain a personal fork of `mpdel`).
Poster
Owner

I can make a patch, given some encouragement that it would be accepted

That would be great, thank you.

> I can make a patch, given some encouragement that it would be accepted That would be great, thank you.
nobrowser commented 1 year ago
Poster

I think this issue belongs in mpdel/libmpdel. Should I create one there? I don't know how to properly cross-reference things on Gitea :-(

Anyway, I just cloned libmpdel and I shall post a pull request soon.

I think this issue belongs in mpdel/libmpdel. Should I create one there? I don't know how to properly cross-reference things on Gitea :-( Anyway, I just cloned libmpdel and I shall post a pull request soon.
Poster
Owner

I think this issue belongs in mpdel/libmpdel.

indeed, only libmpdel should be changed.

Should I create one there?

I think we are fine with the current issue, don't worry.

I don't know how to properly cross-reference things on Gitea :-(

You can just copy the URL and gitea (same as github and gitlab) will shorten it while rendering your comment.

Anyway, I just cloned libmpdel and I shall post a pull request soon.

Thank you.

> I think this issue belongs in mpdel/libmpdel. indeed, only libmpdel should be changed. > Should I create one there? I think we are fine with the current issue, don't worry. > I don't know how to properly cross-reference things on Gitea :-( You can just copy the URL and gitea (same as github and gitlab) will shorten it while rendering your comment. > Anyway, I just cloned libmpdel and I shall post a pull request soon. Thank you.
Poster
Owner

Here is the PR: mpdel/libmpdel#22.

Here is the PR: https://gitea.petton.fr/mpdel/libmpdel/pulls/22.
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.