#33 Edit songs

Open
opened 11 months ago by tangrammer · 5 comments

Hi again!

I'd love to have "Edit Song" functionality inside this library too and also to try to implement it 😄 !

No idea which will be the clean approach for it, lately I was playing with transient and it'd be my initial attempt but I suspect you could prefer to don't add more dependencies and start with a simple and tiny functionality (e.g: edit just genre)

I'll wait for your thoughts!

Hi again! I'd love to have "Edit Song" functionality inside this library too and also to try to implement it 😄 ! No idea which will be the clean approach for it, lately I was playing with [transient](https://github.com/magit/transient) and it'd be my initial attempt but I suspect you could prefer to don't add more dependencies and start with a simple and tiny functionality (e.g: edit just genre) I'll wait for your thoughts!
Poster
Owner

By "edit", do you mean "edit metadata"? It could be really fun! Some ideas:

Before discussing how to implement the feature, I suggest we agree on what the UI/UX should look like.

By "edit", do you mean "edit metadata"? It could be really fun! Some ideas: - look at emms (e.g., through this video https://emacsconf.org/2020/talks/05/, starting at 03:00) - through the customize system? - through a plain org or text buffer? Before discussing how to implement the feature, I suggest we agree on what the UI/UX should look like.
Poster

Sorry, I forgot to add the picture I took to better explain my intention
image

So, ncmpcpp let's you edit a song offering this UI

Sorry, I forgot to add the picture I took to better explain my intention ![image](https://user-images.githubusercontent.com/731829/103880217-1e375480-50d9-11eb-8abb-b5221573a2cb.png) So, ncmpcpp let's you edit a song offering this UI
Poster
Owner

Thanks for the picture. This looks like a much improved version of mpdel-song-mode.

One thing we could do is to improve the mpdel-song-mode to look more like that.
Another thing is to make this major mode somewhat editable.

How would transient help you?

Thanks for the picture. This looks like a much improved version of mpdel-song-mode. One thing we could do is to improve the mpdel-song-mode to look more like that. Another thing is to make this major mode somewhat editable. How would transient help you?
Poster

Hi again!

By "edit", do you mean "edit metadata"? It could be really fun! Some ideas:

Before discussing how to implement the feature, I suggest we agree on what the UI/UX should look like.

well, all these approaches should be great, the emms one seems indeed very similar to ncmpcpp approach!

I just proposed transient thus lately I tried it to have an UI that allow you set options before calling the final command. (was trying to populate a babel source block specifying babel options, attaching a picture here but anyway all magit UIs are based on transient )

And ... thinking twice in why I wanted to have the edit song metadata functionality, I realised that my intention was to be able to search by somesort of tags combination (or genres, at that point I even thought that genres could be multiple ). After reading a bit more about mpd and knowing that basically is an enqueing songs system I'm thinking now that maybe I should try to play more with playlists as tags, so one song could belong to several playlists, and then a user can create a playlist as if they play with sets (merging, difference, exclusions ... )

Sorry about the disgression here 😄 just wanted to share a bit more possible ways of doing mpd in emacs more interesting

Anyhow I keep loving the idea of trying to implement also the meta song editor functionality too (even before the playlist/multi-tag idea) so feel free to choose best approach for it so i can contribute

Hi again! > By "edit", do you mean "edit metadata"? It could be really fun! Some ideas: > > - look at emms (e.g., through this video https://emacsconf.org/2020/talks/05/, starting at 03:00) > - through the customize system? > - through a plain org or text buffer? > > Before discussing how to implement the feature, I suggest we agree on what the UI/UX should look like. well, all these approaches should be great, the emms one seems indeed very similar to ncmpcpp approach! I just proposed transient thus lately I tried it to have an UI that allow you set options before calling the final command. (was trying to populate a babel source block specifying babel options, attaching a picture here but anyway all magit UIs are based on transient ) And ... thinking twice in why I wanted to have the edit song metadata functionality, I realised that my intention was to be able to search by somesort of tags combination (or genres, at that point I even thought that genres could be multiple ). After reading a bit more about mpd and knowing that basically is an enqueing songs system I'm thinking now that maybe I should try to play more with playlists as tags, so one song could belong to several playlists, and then a user can create a playlist as if they play with sets (merging, difference, exclusions ... ) Sorry about the disgression here :smile: just wanted to share a bit more possible ways of doing mpd in emacs more interesting Anyhow I keep loving the idea of trying to implement also the meta song editor functionality too (even before the playlist/multi-tag idea) so feel free to choose best approach for it so i can contribute
Poster
Owner

I don't have any suggestion to edit metadata of a song. I suggest you experiment with something and when you are satisfied you show me what you have done. I think the simplest way would be to make the mpdel-song-mode editable.

I don't plan to use any song-level metadata editor because I most of the time need to edit many files at once (e.g., cleaning metadata after buying or ripping an album).

Regarding your experiment with playlists, feel free to contribute new features in this area too.

I don't have any suggestion to edit metadata of a song. I suggest you experiment with something and when you are satisfied you show me what you have done. I think the simplest way would be to make the mpdel-song-mode editable. I don't plan to use any song-level metadata editor because I most of the time need to edit many files at once (e.g., cleaning metadata after buying or ripping an album). Regarding your experiment with playlists, feel free to contribute new features in this area too.
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.