#22 Add functions / hotkeys to control playback volume

Merged
l3kn merged 1 commits from l3kn/mpdel:master into master 1 year ago
l3kn commented 1 year ago
Collaborator

Resolves issue #21.

I've called the functions "decrease" and "increase"
instead of "decrement" and "increment" and added support for
C-u universal arguments in addition to numeric prefix arguments.

Called with C-u, the volume is increased / decreased
by 4 volume steps.

Resolves issue #21. I've called the functions "decrease" and "increase" instead of "decrement" and "increment" and added support for `C-u` universal arguments in addition to numeric prefix arguments. Called with `C-u`, the volume is increased / decreased by 4 volume steps.
DamienCassou approved these changes 1 year ago
DamienCassou left a comment

Great work. Please fix the docstring of mpdel-core-volume-step to make the checkdoc linter happy.

l3kn commented 1 year ago
Poster
Collaborator

Fixed, I didn't know there was such a tool in emacs,
I'll need to run that on my personal packages, too.

Fixed, I didn't know there was such a tool in emacs, I'll need to run that on my personal packages, too.
Poster
Owner

I didn’t know there was such a tool in emacs

may I suggest you watch my video at EmacsConf? It discusses that kind of tool and how to set them up.

> I didn’t know there was such a tool in emacs may I suggest you watch my video at EmacsConf? It discusses that kind of tool and how to set them up. - https://media.emacsconf.org/2019/16.html
Poster
Owner

Please squash your 2 commits together and merge the PR.

Thank you.

Please squash your 2 commits together and merge the PR. Thank you.
l3kn commented 1 year ago
Poster
Collaborator

may I suggest you watch my video at EmacsConf? It discusses that kind of tool and how to set them up.

Thanks, I'll take a look at that.

Please squash your 2 commits together and merge the PR.

The commits are squashed, however I don't see an option to merge this PR,
maybe I'm missing permissions to make changes to this repo?

> may I suggest you watch my video at EmacsConf? It discusses that kind of tool and how to set them up. Thanks, I'll take a look at that. > Please squash your 2 commits together and merge the PR. The commits are squashed, however I don't see an option to merge this PR, maybe I'm missing permissions to make changes to this repo?
Poster
Owner

I don’t see an option to merge this PR, maybe I’m missing permissions to make changes to this repo?

I changed the permissions. Can you merge now?

> I don’t see an option to merge this PR, maybe I’m missing permissions to make changes to this repo? I changed the permissions. Can you merge now?
l3kn commented 1 year ago
Poster
Collaborator

I changed the permissions. Can you merge now?
I still only see a "Close" and a "Comment" button

> I changed the permissions. Can you merge now? I still only see a "Close" and a "Comment" button
Poster
Owner

I did some more changes to the settings. Is it better now?

I did some more changes to the settings. Is it better now?
l3kn closed this pull request 1 year ago
l3kn commented 1 year ago
Poster
Collaborator

Thanks, now merging it myself worked.

Thanks, now merging it myself worked.
The pull request has been merged as 1edec10eb3.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.