[#31] Implement navigel-delete for stored-playlists

New Pull Request

Conversation 2 Commits 1 Files Changed 1

There is no content yet.

tangrammer added 1 commit 3 months ago

6e205354e3 [#31 ] Implement navigel-delete for stored-playlists

DamienCassou requested changes 3 months ago

Thank you!

mpdel-playlist.el Outdated

												
					  (libmpdel-playlist-delete songs navigel-entity))
				
					(navigel-method mpdel navigel-delete ((stored-playlists list) &context (major-mode mpdel-browser-mode) &optional _callback)

DamienCassou commented 3 months ago

mpdel-browser-mode stuff should probably be in mpdel-browser.el.

tangrammer added 1 commit 3 months ago

2cb2df1c6c [#31 ] Refactor: Moving mpdel-browser-mode logic to mpdel-browser.el

tangrammer force-pushed master from 2cb2df1c6c to d4cb7638de 3 months ago

DamienCassou requested changes 3 months ago

Can you please squash the 2 commits into 1 and make sure the commit doesn't change mpdel-playlist.el?

tangrammer force-pushed master from d4cb7638de to 354c458eb4 3 months ago

here you are!

tangrammer requested review from DamienCassou 3 months ago

DamienCassou merged commit 6682446c62 into master 3 months ago

DamienCassou referenced this issue from a commit 3 months ago

Merge pull request '[#31] Implement navigel-delete for stored-playlists' (#32) from tangrammer/mpdel:master into master

Thank you very much!

Reviewers

DamienCassou was requested for review 3 months ago

The pull request has been merged as 6682446c62.

Sign in to join this conversation.

DamienCassou

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

			(libmpdel-playlist-delete songs navigel-entity))


			(navigel-method mpdel navigel-delete ((stored-playlists list) &context (major-mode mpdel-browser-mode) &optional _callback)

#32 [#31] Implement navigel-delete for stored-playlists

Reviewers