#2 Weird code

Closed
opened 6 months ago by nico · 2 comments
nico commented 6 months ago

indium-webkit.el has this strange line of code:

(cl-defmethod (setf indium-connection-ws) (ws (connection indium-connection))
  ...)

is that normal? The compiler reports it as a warning:

indium-webkit.el:668:1:Warning: the function ‘(setf indium-current-connection-callbacks)’ is not known to be defined.


Issue migrated from Gitlab

  • Original author: @DamienCassou
  • Created: 2017-07-22T12:53:38.582Z
  • Updated: 2017-07-22T21:51:10.673Z
`indium-webkit.el` has this strange line of code: ```emacs (cl-defmethod (setf indium-connection-ws) (ws (connection indium-connection)) ...) ``` is that normal? The compiler reports it as a warning: > indium-webkit.el:668:1:Warning: the function ‘(setf indium-current-connection-callbacks)’ is not known to be defined. ----- #### Issue migrated from Gitlab - Original author: @DamienCassou - Created: 2017-07-22T12:53:38.582Z - Updated: 2017-07-22T21:51:10.673Z
nico commented 6 months ago
Owner

closed via commit fd792dd70a


Comment migrated from Gitlab

  • Original author: @nico
  • Created: 2017-07-22T21:46:56.627Z
  • Updated: 2017-07-22T21:46:56.627Z
closed via commit fd792dd70a312a33a7458b4fa0bd7d5fb5f95e95 ----- #### Comment migrated from Gitlab - Original author: @nico - Created: 2017-07-22T21:46:56.627Z - Updated: 2017-07-22T21:46:56.627Z
nico commented 6 months ago
Owner

That's setf setter definition for an object of type indium-connection.

See indium-structs.el for more definitions, and gv.el's documentation if you're looking for how setf works and can be extended.

indium-webkit.el:668:1:Warning: the function ‘(setf indium-current-connection-callbacks)’ is not known to be defined.

It's actually a warning for a different method. A setf setter was indeed missing for the callbacks, I added one, thanks.


Comment migrated from Gitlab

  • Original author: @nico
  • Created: 2017-07-22T21:51:10.648Z
  • Updated: 2017-07-22T21:51:10.648Z
That's setf setter definition for an object of type `indium-connection`. See `indium-structs.el` for more definitions, and `gv.el`'s documentation if you're looking for how setf works and can be extended. >> indium-webkit.el:668:1:Warning: the function ‘(setf >> indium-current-connection-callbacks)’ is not known to be defined. It's actually a warning for a different method. A setf setter was indeed missing for the callbacks, I added one, thanks. ----- #### Comment migrated from Gitlab - Original author: @nico - Created: 2017-07-22T21:51:10.648Z - Updated: 2017-07-22T21:51:10.648Z
Sign in to join this conversation.
No Label
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.